Nuvoton: Fix crypto compile error with Mbed OS 2 #9191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccli8, thank you for your changes. |
|
@screamerbg Please recheck when able. |
Replace Mutex with PlatformMutex which supports RTOS-absent
ccli8
force-pushed
the
nuvoton_fix_crypto_no-rtos
branch
from
a57b50f to
39f705e
Compare
|
I make the following modifications:
|
0xc0170
previously requested changes
Jan 2, 2019
| @@ -19,15 +19,16 @@ | |||
| #include "mbed_assert.h" | |||
| #include "mbed_critical.h" | |||
| #include "mbed_error.h" | |||
| #if defined(MBED_CONF_RTOS_PRESENT) && MBED_CONF_RTOS_PRESENT | |||
There was a problem hiding this comment.
We shall just use #if MBED_CONF_RTOS_PRESENT, we consolidated recently drivers to use this as well (no toolchain should warn if not defined, should be set to 0).
cmonr
approved these changes
Jan 3, 2019
|
@screamerbg Would you mind retesting the bootloader project? Will run CI in the meantime since this appears to be ready. |
|
CI started |
|
We stopped the test as 5.11.1 rc needs to be completed first, will restart as soon as it completes |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
CI restarted |
0xc0170
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to fix #9081 which causes crypto compile error with Mbed OS 2 for Nuvoton targets.
Related PR or issue
#9081
#9190
Related targets
Pull request type
Reviewers